Fix for RemoveRedundantToStringCall(RCS1097) #1037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour:
It looks as if this was attempted to be prevented by using an IsReferenceType check at:
https://github.com/JosefPihrt/Roslynator/blob/3c6f1c1fc24b63aea6b0d82e64ec4e02d9ca39ad/src/Analyzers/CSharp/Analysis/RemoveRedundantToStringCallAnalysis.cs#L60
Unfortunately, this doesn't work for structs as they have type System.ValueType which is considered a reference type. See
https://learn.microsoft.com/en-us/dotnet/api/system.type.isvaluetype?redirectedfrom=MSDN&view=net-7.0#System_Type_IsValueType
Fix implemented just explicitly checks for
System_ValueType
.Also added a test to catch future regressions.