Fix RCS1146 #1098
Merged
Fix RCS1146 #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
Jun 22, 2023
| @@ -274,6 +274,14 @@ static bool ExistsImplicitConversionToBoolean(INamedTypeSymbol typeSymbol) | |||
| case SyntaxKind.GreaterThanOrEqualExpression: | |||
| case SyntaxKind.EqualsExpression: | |||
| { | |||
| var leftTypeSymbol = semanticModel.GetTypeSymbol(((BinaryExpressionSyntax)expression).Left); | |||
| if (leftTypeSymbol.IsValueType && leftTypeSymbol.SpecialType is SpecialType.None) | |||
There was a problem hiding this comment.
I would rather use CSharpFacts.IsPredefinedType instead of is SpecialTypen.None.
josefpihrt
requested changes
Jun 24, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
josefpihrt
approved these changes
Jun 27, 2023
|
👍 |
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have the following expression and the field F is a value type then we cannot apply RCS1146 as this will mean that a different overload of
==is used (and one may not exist).We know that the
==operator exists and works correctly for in-built value types like int so the diagnostic can still be suggested for those cases.