Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce work in loop #2026

Merged
merged 1 commit into from
Nov 30, 2024
Merged

fix: reduce work in loop #2026

merged 1 commit into from
Nov 30, 2024

Conversation

pjonsson
Copy link
Contributor

PR Checklist

Overview

Make the case for the void type
mutually exclusive with the other
check in the loop.

Suggested in #2025 (comment).

@pjonsson
fix: reduce work in loop
98381b8 
Make the case for the void type
mutually exclusive with the other
check in the loop.
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (6bfc044) to head (98381b8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
- Coverage   80.04%   80.04%   -0.01%     
==========================================
  Files         171      171              
  Lines       10736    10734       -2     
  Branches     1030     1030              
==========================================
- Hits         8594     8592       -2     
  Misses       2137     2137              
  Partials        5        5
Flag Coverage Δ
mutation 74.24% <100.00%> (-0.01%) ⬇️
unit 28.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 30, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great first PR. 🙂

@JoshuaKGoldberg JoshuaKGoldberg merged commit e53514f into JoshuaKGoldberg:main Nov 30, 2024
13 of 14 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @pjonsson for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Nov 30, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @pjonsson! 🎉

@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.8.3 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Nov 30, 2024
@allcontributors
docs: add pjonsson as a contributor for code (#2027)
774e265 
Adds @pjonsson as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#2026 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@pjonsson pjonsson deleted the avoid-work-in-loop branch November 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjonsson @JoshuaKGoldberg