Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add emojis from emoji-mart (Bluesky) #14

Open
2 tasks done
JoshuaKGoldberg opened this issue Mar 22, 2024 · 2 comments
Open
2 tasks done

🚀 Feature: Add emojis from emoji-mart (Bluesky) #14

JoshuaKGoldberg opened this issue Mar 22, 2024 · 2 comments
Labels
platform support Adding emojis from a not-yet-supported platform ➕ status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 22, 2024

Bug Report Checklist

Overview

Mentioned by @vladimyr.bsky.social: https://bsky.app/profile/vladimyr.bsky.social/post/3kobo3z4ieo2b:

I was wondering what Bluseky's webapp uses and found another potential platform data source: github.com/missive/emoj...

It includes related keywords:

$ curl -sL 'https://github.com/missive/emoji-mart/raw/main/packages/emoji-mart-data/sets/15/native.json' | jq '.emojis.airplane_departure'

Yes!! This is a great idea. I should have thought of searching Bluesky 😄. Accepting PRs!

https://github.com/missive/emoji-mart

Additional Info

I'd mentioned in muan/emojilib#194 (comment) that a few emojis didn't have keywords in any existing platforms:

  • 🐙 went from 7 keywords to 1: octopus
    ...
    None of the platforms in emoji-platform-data have more than 1-2 keywords for them. Adding in a more rich platform would fill back in those missing keywords. For example, asking the native macOS emoji picker for sea includes 🐙 in the results. I added emoji-platform-data issues labeled platform support.

Looks like emoji-mart has a lot of good keywords, including 🐙!

"octopus": {
  "id": "octopus",
  "name": "Octopus",
  "keywords": ["animal", "creature", "ocean", "sea", "nature", "beach"],
  "skins": [{ "unified": "1f419", "native": "🐙" }],
  "version": 1
}

Co-authored-by: @vladimyr

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 platform support Adding emojis from a not-yet-supported platform ➕ status: accepting prs Please, send a pull request to resolve this! 🙏 labels Mar 22, 2024
@JoshuaKGoldberg
Copy link
Owner Author

@allcontributors add @vladimyr for ideas

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @vladimyr! 🎉

JoshuaKGoldberg pushed a commit that referenced this issue Mar 22, 2024
Adds @vladimyr as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#14 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform support Adding emojis from a not-yet-supported platform ➕ status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

1 participant