Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

🐛 Bug: Comments that include eslint-disable get flagged erroneously #6

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 11, 2023 · 4 comments · Fixed by #3
Closed
3 tasks done

🐛 Bug: Comments that include eslint-disable get flagged erroneously #6

JoshuaKGoldberg opened this issue Dec 11, 2023 · 4 comments · Fixed by #3
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This should not be flagged as a disable:

/* we-should-never-eslint-disable one-var */

Actual

Right now, it is.

Additional Info

Reported by @StyleShit via #3. I'm filing this issue for tracking + to make it easier to give allcontributors recognition to @StyleShit. 🙂

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( 🐛 status: accepting prs Please, send a pull request to resolve this! 🙏 labels Dec 11, 2023
@JoshuaKGoldberg
Copy link
Owner Author

@allcontributors add @StyleShit for bug

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @StyleShit! 🎉

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant