Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: BREAKING CHANGE: not recognised #507

Open
3 tasks done
johnnyreilly opened this issue Dec 7, 2024 · 6 comments
Open
3 tasks done

🐛 Bug: BREAKING CHANGE: not recognised #507

johnnyreilly opened this issue Dec 7, 2024 · 6 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@johnnyreilly
Copy link

johnnyreilly commented Dec 7, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

BREAKING CHANGE: to be detected as a breaking change release

Actual

Checking commit: BREAKING CHANGE: registry feature and change shortcuts
Found type undefined. Continuing.

See https://github.com/johnnyreilly/azdo-npm-auth/actions/runs/12215799512/job/34078200073#step:5:11

Additional Info

johnnyreilly/azdo-npm-auth#20

It looks that feat!: is also not recognised - same log messages:

johnnyreilly/azdo-npm-auth#21

https://github.com/johnnyreilly/azdo-npm-auth/actions/runs/12215949788/job/34078528733#step:5:11

Looking at #140 it suggests this ought to work. But it doesn't. Or I'm missing something

@johnnyreilly johnnyreilly added the type: bug Something isn't working :( label Dec 7, 2024
@JoshuaKGoldberg
Copy link
Owner

Heh, #140 was never merged, and I never followed up on the detection it was meant to add. Would definitely accept a remake of it (or an equivalent addition)!

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Dec 7, 2024
@johnnyreilly
Copy link
Author

johnnyreilly commented Dec 7, 2024

ah - so I think the docs are wrong then. Shame. TBH right now I just want to ship a release. The 1.0.0 style functionality also doesn't work. https://github.com/johnnyreilly/azdo-npm-auth/actions/runs/12216038121/job/34078723130#step:5:12

@johnnyreilly
Copy link
Author

Baffled as to why these tests are passing: https://github.com/JoshuaKGoldberg/should-semantic-release/blob/main/src/getCommitMeaning.test.ts

Anyway, I think I need to hack my package.json to get past this for now

@JoshuaKGoldberg
Copy link
Owner

Oh! #168 was merged later on.

@johnnyreilly
Copy link
Author

There https://github.com/johnnyreilly/azdo-npm-auth/actions/runs/12216118613/job/34078891515 - I feel a little dirty, but I shipped!

@johnnyreilly
Copy link
Author

johnnyreilly commented Dec 7, 2024

I don't know why #168 doesn't appear to be working for me - but I've managed to work around the issue at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

2 participants