Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Does not include new packages #185

Closed
3 tasks done
sindresorhus opened this issue Dec 13, 2023 · 5 comments · Fixed by #186 or JoshuaKGoldberg/tidelift-me-up-site#211
Closed
3 tasks done

🐛 Bug: Does not include new packages #185

sindresorhus opened this issue Dec 13, 2023 · 5 comments · Fixed by #186 or JoshuaKGoldberg/tidelift-me-up-site#211
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@sindresorhus
Copy link

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I expected it to include new packages.

Actual

It does not include packages created after 2023-01-13 because the API is no longer updating:

Additional Info

No response
@sindresorhus sindresorhus added the type: bug Something isn't working :( label Dec 13, 2023
@JoshuaKGoldberg
Copy link
Owner

OH! Well that explains it. Thanks for the heads up. I'll look into retrieving data from https://registry.npmjs.org or an equivalent instead.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Dec 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 14, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 14, 2023
@JoshuaKGoldberg
fix: directly query npm instead of via npms (#186)
26214aa 
## PR Checklist

- [x] Addresses an existing open issue: fixes #185
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/tidelift-me-up/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/tidelift-me-up/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Switches to the npm API. The `PackageData` structure seems to be just
about the same as npms, which makes this pretty much not a breaking
change. Yay!

Example base query for searching:
https://registry.npmjs.com/-/v1/search?&text=maintainer:joshuakgoldberg
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @sindresorhus for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Dec 14, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @sindresorhus! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Dec 14, 2023
@allcontributors
docs: add sindresorhus as a contributor for bug (#187)
ab9eeda 
Adds @sindresorhus as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#185 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 14, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit to JoshuaKGoldberg/tidelift-me-up-site that referenced this issue Dec 14, 2023
@JoshuaKGoldberg
fix: bump tidelift-me-up to 0.2.0 (#211)
709a902 
## PR Checklist

- [x] Addresses an existing open issue: fixes #000
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Brings in JoshuaKGoldberg/tidelift-me-up#186,
which fixed
JoshuaKGoldberg/tidelift-me-up#185.
@opensrc0
Copy link

opensrc0 commented Jun 6, 2024

I'm having the same issue.

My Package1: https://api.npms.io/v2/package/fe-theme (Working)
My Package2: https://api.npms.io/v2/package/fe-pilot (Not working)

@JoshuaKGoldberg
Copy link
Owner

@opensrc0 it looks like you're looing at the npms.io API? This repository is for tidelift-me-up, a tool that used to use that API. As of #186 tidelift-me-up uses the npm registry itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
3 participants
@sindresorhus @JoshuaKGoldberg @opensrc0