-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Types #41
Generic Types #41
Conversation
…o onChange function
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 99.5% 99.51% +<.01%
==========================================
Files 14 14
Lines 204 207 +3
Branches 40 41 +1
==========================================
+ Hits 203 206 +3
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking mighty good already, made a few minor comment, also shouldn't we change Field and FieldArray as well?
Used partial types in callback methods as we cannot be certain what values are present and which ones are not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'll merge this in, write docs this week and release it by the end of the week
This PR adds generic types to all hooks except useFormConnect.
Fixes: #34