Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide empty repos #299

Closed
yourh3ro opened this issue Apr 27, 2023 · 3 comments
Closed

[Feature] Hide empty repos #299

yourh3ro opened this issue Apr 27, 2023 · 3 comments
Milestone

Comments

@yourh3ro
Copy link

When all tags are removed from the repository, it still continues to be displayed, which is misleading.
I suggest adding a setting to hide\display empty repositories.

@Joxit
Copy link
Owner

Joxit commented Apr 27, 2023

Hi, thank you for using my project and submitting feature requests.

In order to filter empty repositories, I have to, for each repositories, do a call to the API. This is already done when SHOW_CATALOG_NB_TAGS is activated.

What I can do is, when SHOW_CATALOG_NB_TAGS is true, I hide all empty repositories. Is it fine for you (instead of having a new option) ?

@yourh3ro
Copy link
Author

In my case, it worked perfectly, but perhaps the project will lose flexibility.
I myself cannot imagine a situation that someone needs to see that he has 0 tags in any section, but I do not exclude that people may have any processes that presuppose viewing empty repositories (for example, just for the sake of nostalgia, lol).

I want to say that this solution would suit me, but it's up to you to decide how to make it easier and more correct.

@Joxit Joxit added this to the 2.5.0 milestone Apr 30, 2023
@Joxit Joxit closed this as completed in b081108 Apr 30, 2023
@Joxit
Copy link
Owner

Joxit commented Apr 30, 2023

Yes I know, this is a limitation of Docker Registry Server, the server should have deleted these images, but it doesn't work like that... See #77

IMO adding this new option will duplicate with SHOW_CATALOG_NB_TAGS since now it's supporting it now.

So it will be an option that will generate x new requests (the number of images) just like SHOW_CATALOG_NB_TAGS without the nice addition of SHOW_CATALOG_NB_TAGS.

So this addition is available in main tag for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants