Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mapping for UpdateGlobalNftLimit proposal type #4853

Closed
zeeshanakram3 opened this issue Sep 4, 2023 · 0 comments · Fixed by #4856
Closed

Implement mapping for UpdateGlobalNftLimit proposal type #4853

zeeshanakram3 opened this issue Sep 4, 2023 · 0 comments · Fixed by #4856
Assignees
Labels
bug Something isn't working query-node

Comments

@zeeshanakram3
Copy link
Contributor

Context

Discovered while working on #4842

In the ProposalCreated mappings, the condition for checking proposalDetails.type === "UpdateGlobalNftLimit" does not exist. And since the ProposalCreated mappings throw an error for unimplemented/unsupported proposal types, this mapping would throw an exception when the UpdateGlobalNftLimit proposal type is unfiltered (in future runtime upgrade) and a proposal is created of this type.

throw new Error(`Unspported proposal details type: ${proposalDetails.type}`)

Fix

Handle the UpdateGlobalNftLimit proposal type in the mapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working query-node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant