Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle actions by Lead as ContentActor #4855

Closed
zeeshanakram3 opened this issue Sep 5, 2023 · 0 comments · Fixed by #4856
Closed

Gracefully handle actions by Lead as ContentActor #4855

zeeshanakram3 opened this issue Sep 5, 2023 · 0 comments · Fixed by #4856

Comments

@zeeshanakram3
Copy link
Contributor

Context

Discovered while working on #4842

If the content Lead creates a video with an autoIssueNft parameter set, then the mappings would crash as mappings currently don't recognize Lead as a valid content actor. This issue is present in many other mappings such as OpenAuctionStarted, EnglishAuctionStarted, NFTIssued etc. because a common function (convertContentActorToChannelOrNftOwner) is used everywhere.

joystream/query-node/mappings/src/content/utils.ts

Line 446 in d144823

throw new Error('Not-implemented ContentActor type used')

image

Fix

Gracefully handle actions by Lead as ContentActor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QN mappings review & fixes zeeshanakram3/joystream
1 participant
@zeeshanakram3