From 54d661f03290688ef45b2aafc2452891f5b6e99e Mon Sep 17 00:00:00 2001
From: Lezek123 <leszek@jsgenesis.com>
Date: Fri, 8 Nov 2024 11:39:44 +0100
Subject: [PATCH] 4.1.1.: Video relevance fixes

---
 CHANGELOG.md                                  | 16 +++++++
 package.json                                  |  2 +-
 src/mappings/content/commentsAndReactions.ts  |  8 +---
 src/mappings/content/nft.ts                   |  2 +-
 src/mappings/content/utils.ts                 | 12 +----
 src/mappings/content/video.ts                 |  3 +-
 src/mappings/token/index.ts                   |  3 +-
 src/mappings/utils.ts                         |  9 ----
 src/processor.ts                              | 25 ++++++++++-
 .../resolvers/AdminResolver/index.ts          |  8 ++--
 .../resolvers/AdminResolver/utils.ts          | 11 +++--
 .../resolvers/ChannelsResolver/index.ts       |  4 +-
 .../resolvers/VideosResolver/index.ts         |  4 +-
 src/server-extension/utils.ts                 | 12 +++++
 src/utils/VideoRelevanceManager.ts            | 44 +++++++++++++------
 src/utils/notification/helpers.ts             | 16 ++++++-
 16 files changed, 117 insertions(+), 62 deletions(-)
 create mode 100644 src/server-extension/utils.ts

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f22ae2db5..b25f45491 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,19 @@
+# 4.1.1
+
+## Affected components:
+- Processor (non-breaking changes)
+- GraphQL server (non-breaking changes)
+
+## Bug Fixes:
+- Fixed video relevance calculation algorithm by:
+    - Ignoring `publishedBeforeJoystream` date if it's in the future,
+    - Fixing a bug with Joystream/YT creation weight formula,
+    - Introduced an age limit of 365 days to prevent negative relevance score 
+- Fixed ineffective `videoRelevanceManager` calls in GraphQL server due to `videoRelevanceManager` not being turned on.
+- Fixed a bug causing both GraphQL server and Processor services to run video relevance and language update loops (which only processor should be running)
+- Fixed imports in GraphQl server and Processor by moving shared utilities to root `utils` directory to prevent mix-ups.
+
+
 # 4.1.0
 
 ## Affected components:
diff --git a/package.json b/package.json
index 7d453b353..df5f4af1a 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "orion",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "engines": {
     "node": ">=16"
   },
diff --git a/src/mappings/content/commentsAndReactions.ts b/src/mappings/content/commentsAndReactions.ts
index 12fbe909a..44c9e16b7 100644
--- a/src/mappings/content/commentsAndReactions.ts
+++ b/src/mappings/content/commentsAndReactions.ts
@@ -53,13 +53,9 @@ import {
   commentCountersManager,
   videoRelevanceManager,
 } from '../utils'
-import {
-  getAccountForMember,
-  getChannelOwnerMemberByChannelId,
-  memberHandleById,
-  parseVideoTitle,
-} from './utils'
+import { getAccountForMember, getChannelOwnerMemberByChannelId, memberHandleById } from './utils'
 import { addNotification } from '../../utils/notification'
+import { parseVideoTitle } from '../../utils/notification/helpers'
 
 function parseVideoReaction(reaction: ReactVideo.Reaction): VideoReactionOptions {
   const protobufReactionToGraphqlReaction = {
diff --git a/src/mappings/content/nft.ts b/src/mappings/content/nft.ts
index dfeb5f579..80238bc0e 100644
--- a/src/mappings/content/nft.ts
+++ b/src/mappings/content/nft.ts
@@ -53,9 +53,9 @@ import {
   notifyBiddersOnAuctionCompletion,
   notifyChannelFollowers,
   parseContentActor,
-  parseVideoTitle,
   processNft,
 } from './utils'
+import { parseVideoTitle } from '../../utils/notification/helpers'
 
 export async function processOpenAuctionStartedEvent({
   overlay,
diff --git a/src/mappings/content/utils.ts b/src/mappings/content/utils.ts
index ea83f2eae..4ebc8e59c 100644
--- a/src/mappings/content/utils.ts
+++ b/src/mappings/content/utils.ts
@@ -75,6 +75,7 @@ import { criticalError } from '../../utils/misc'
 import { addNotification } from '../../utils/notification'
 import { EntityManagerOverlay, Flat } from '../../utils/overlay'
 import { addNftActivity, addNftHistoryEntry, genericEventFields, invalidMetadata } from '../utils'
+import { parseChannelTitle, parseVideoTitle } from '../../utils/notification/helpers'
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type AsDecoded<MetaClass> = MetaClass extends { create: (props?: infer I) => any }
@@ -887,14 +888,6 @@ export function increaseChannelCumulativeRevenue(channel: Flat<Channel>, amount:
   channel.cumulativeRevenue = (channel.cumulativeRevenue || 0n) + amount
 }
 
-export function parseChannelTitle(channel: Flat<Channel>): string {
-  return channel.title || FALLBACK_CHANNEL_TITLE
-}
-
-export function parseVideoTitle(video: Flat<Video>): string {
-  return video.title || FALLBACK_VIDEO_TITLE
-}
-
 export async function memberHandleById(
   overlay: EntityManagerOverlay,
   memberId: string
@@ -908,6 +901,3 @@ export async function getChannelTitleById(overlay: EntityManagerOverlay, channel
   const channel = await overlay.getRepository(Channel).getByIdOrFail(channelId)
   return parseChannelTitle(channel)
 }
-
-export const FALLBACK_CHANNEL_TITLE = '??'
-export const FALLBACK_VIDEO_TITLE = '??'
diff --git a/src/mappings/content/video.ts b/src/mappings/content/video.ts
index 7249b2d42..964d580a2 100644
--- a/src/mappings/content/video.ts
+++ b/src/mappings/content/video.ts
@@ -29,12 +29,11 @@ import {
   deleteVideo,
   encodeAssets,
   notifyChannelFollowers,
-  parseChannelTitle,
   parseContentActor,
-  parseVideoTitle,
   processAppActionMetadata,
   processNft,
 } from './utils'
+import { parseChannelTitle, parseVideoTitle } from '../../utils/notification/helpers'
 
 export async function processVideoCreatedEvent({
   overlay,
diff --git a/src/mappings/token/index.ts b/src/mappings/token/index.ts
index dedf543f1..e67473471 100644
--- a/src/mappings/token/index.ts
+++ b/src/mappings/token/index.ts
@@ -45,7 +45,7 @@ import { getCurrentBlockHeight } from '../../utils/blockHeight'
 import { EventHandlerContext } from '../../utils/events'
 import { criticalError } from '../../utils/misc'
 import { addNotification } from '../../utils/notification'
-import { getChannelOwnerAccount, notifyChannelFollowers, parseChannelTitle } from '../content/utils'
+import { getChannelOwnerAccount, notifyChannelFollowers } from '../content/utils'
 import { deserializeMetadata, genericEventFields } from '../utils'
 import {
   VestingScheduleData,
@@ -60,6 +60,7 @@ import {
   processTokenMetadata,
   processValidatedTransfers,
 } from './utils'
+import { parseChannelTitle } from '../../utils/notification/helpers'
 
 export async function processTokenIssuedEvent({
   overlay,
diff --git a/src/mappings/utils.ts b/src/mappings/utils.ts
index 4f2da75f3..0e5ed6e7d 100644
--- a/src/mappings/utils.ts
+++ b/src/mappings/utils.ts
@@ -15,15 +15,6 @@ import { OrionVideoLanguageManager } from '../utils/OrionVideoLanguageManager'
 export const orionVideoLanguageManager = new OrionVideoLanguageManager()
 export const commentCountersManager = new CommentCountersManager()
 export const videoRelevanceManager = new VideoRelevanceManager()
-// eslint-disable-next-line no-void
-void orionVideoLanguageManager.init(
-  1000 * 60 * 5 // 5 mins
-)
-// eslint-disable-next-line no-void
-void videoRelevanceManager.init({
-  fullUpdateLoopTime: 1000 * 60 * 60 * 12, // 12 hrs
-  scheduledUpdateLoopTime: 1000 * 60 * 10, // 10 mins
-})
 export const JOYSTREAM_SS58_PREFIX = 126
 
 export function bytesToString(b: Uint8Array): string {
diff --git a/src/processor.ts b/src/processor.ts
index 3199b0a24..cc92ff6d5 100644
--- a/src/processor.ts
+++ b/src/processor.ts
@@ -113,7 +113,11 @@ import {
   processUpcomingTokenSaleUpdatedEvent,
   processUserParticipatedInSplitEvent,
 } from './mappings/token'
-import { commentCountersManager, videoRelevanceManager } from './mappings/utils'
+import {
+  commentCountersManager,
+  videoRelevanceManager,
+  orionVideoLanguageManager,
+} from './mappings/utils'
 import { Event } from './types/support'
 import { EventHandler, EventInstance, EventNames, eventConstructors } from './utils/events'
 import { assertAssignable } from './utils/misc'
@@ -363,6 +367,25 @@ async function afterDbUpdate(em: EntityManager) {
 }
 
 const offchainState = new OffchainState()
+
+// Initialize update intervals
+orionVideoLanguageManager
+  .init(
+    1000 * 60 * 5 // 5 mins
+  )
+  .catch((e) => {
+    throw new Error(`Failed to initialize Orion video language manager: ${e.toString()}`)
+  })
+
+videoRelevanceManager
+  .init({
+    fullUpdateLoopTime: 1000 * 60 * 60 * 12, // 12 hrs
+    scheduledUpdateLoopTime: 1000 * 60 * 10, // 10 mins
+  })
+  .catch((e) => {
+    throw new Error(`Failed to initialize Orion video relevance manager: ${e.toString()}`)
+  })
+
 let exportBlockNumber: number
 
 processor.run(new TypeormDatabase({ isolationLevel: 'READ COMMITTED' }), async (ctx) => {
diff --git a/src/server-extension/resolvers/AdminResolver/index.ts b/src/server-extension/resolvers/AdminResolver/index.ts
index d4966fe28..2c02188ba 100644
--- a/src/server-extension/resolvers/AdminResolver/index.ts
+++ b/src/server-extension/resolvers/AdminResolver/index.ts
@@ -11,8 +11,6 @@ import { GraphQLResolveInfo } from 'graphql'
 import 'reflect-metadata'
 import { Args, Ctx, Info, Int, Mutation, Query, Resolver, UseMiddleware } from 'type-graphql'
 import { EntityManager, In, Not, UpdateResult } from 'typeorm'
-import { parseVideoTitle } from '../../../mappings/content/utils'
-import { videoRelevanceManager } from '../../../mappings/utils'
 import {
   Account,
   Channel,
@@ -76,6 +74,8 @@ import {
   VideoWeights,
 } from './types'
 import { processCommentsCensorshipStatusUpdate } from './utils'
+import { recalculateAllVideosRelevance } from '../../utils'
+import { parseVideoTitle } from '../../../utils/notification/helpers'
 
 @Resolver()
 export class AdminResolver {
@@ -161,7 +161,7 @@ export class AdminResolver {
       ],
       em
     )
-    await videoRelevanceManager.updateVideoRelevanceValue(em, true)
+    await recalculateAllVideosRelevance(em)
     return { isApplied: true }
   }
 
@@ -222,7 +222,7 @@ export class AdminResolver {
         }
       )
 
-      await videoRelevanceManager.updateVideoRelevanceValue(em, true)
+      await recalculateAllVideosRelevance(em)
 
       // Push the result into the results array
       results.push({
diff --git a/src/server-extension/resolvers/AdminResolver/utils.ts b/src/server-extension/resolvers/AdminResolver/utils.ts
index 91ac740ab..23a7fd780 100644
--- a/src/server-extension/resolvers/AdminResolver/utils.ts
+++ b/src/server-extension/resolvers/AdminResolver/utils.ts
@@ -1,14 +1,13 @@
 import { EntityManager, In } from 'typeorm'
-import { CommentCountersManager } from '../../../utils/CommentsCountersManager'
 import { Comment } from '../../../model'
+import { commentCountersManager } from '../../utils'
 
 export async function processCommentsCensorshipStatusUpdate(em: EntityManager, ids: string[]) {
-  const manager = new CommentCountersManager()
   const comments = await em.getRepository(Comment).find({ where: { id: In(ids) } })
   comments.forEach((c) => {
-    manager.scheduleRecalcForComment(c.parentCommentId)
-    manager.scheduleRecalcForVideo(c.videoId)
+    commentCountersManager.scheduleRecalcForComment(c.parentCommentId)
+    commentCountersManager.scheduleRecalcForVideo(c.videoId)
   })
-  await manager.updateVideoCommentsCounters(em)
-  await manager.updateParentRepliesCounters(em)
+  await commentCountersManager.updateVideoCommentsCounters(em)
+  await commentCountersManager.updateParentRepliesCounters(em)
 }
diff --git a/src/server-extension/resolvers/ChannelsResolver/index.ts b/src/server-extension/resolvers/ChannelsResolver/index.ts
index 06ab2a602..82395a5d5 100644
--- a/src/server-extension/resolvers/ChannelsResolver/index.ts
+++ b/src/server-extension/resolvers/ChannelsResolver/index.ts
@@ -53,8 +53,8 @@ import { uniqueId } from '../../../utils/crypto'
 import { AccountOnly, OperatorOnly, UserOnly } from '../middleware'
 import { addNotification } from '../../../utils/notification'
 import { assertNotNull } from '@subsquid/substrate-processor'
-import { FALLBACK_CHANNEL_TITLE } from '../../../mappings/content/utils'
 import pLimit from 'p-limit'
+import { parseChannelTitle } from '../../../utils/notification/helpers'
 
 @Resolver()
 export class ChannelsResolver {
@@ -463,7 +463,7 @@ export const excludeChannelService = async (
         em,
         account,
         new MemberRecipient({ membership: channelOwnerMemberId }),
-        new ChannelExcluded({ channelTitle: channel.title ?? FALLBACK_CHANNEL_TITLE })
+        new ChannelExcluded({ channelTitle: parseChannelTitle(channel) })
       )
     }
 
diff --git a/src/server-extension/resolvers/VideosResolver/index.ts b/src/server-extension/resolvers/VideosResolver/index.ts
index 63b0a847d..bbd36f3b1 100644
--- a/src/server-extension/resolvers/VideosResolver/index.ts
+++ b/src/server-extension/resolvers/VideosResolver/index.ts
@@ -21,8 +21,6 @@ import { isObject } from 'lodash'
 import 'reflect-metadata'
 import { Arg, Args, Ctx, Info, Mutation, Query, Resolver, UseMiddleware } from 'type-graphql'
 import { EntityManager, In, MoreThan } from 'typeorm'
-import { parseVideoTitle } from '../../../mappings/content/utils'
-import { videoRelevanceManager } from '../../../mappings/utils'
 import {
   Account,
   ChannelRecipient,
@@ -53,6 +51,8 @@ import {
   SetOrUnsetPublicFeedResult,
   VideoReportInfo,
 } from './types'
+import { videoRelevanceManager } from '../../utils'
+import { parseVideoTitle } from '../../../utils/notification/helpers'
 
 @Resolver()
 export class VideosResolver {
diff --git a/src/server-extension/utils.ts b/src/server-extension/utils.ts
new file mode 100644
index 000000000..1e7f3ecd8
--- /dev/null
+++ b/src/server-extension/utils.ts
@@ -0,0 +1,12 @@
+import { EntityManager } from 'typeorm'
+import { CommentCountersManager } from '../utils/CommentsCountersManager'
+import { VideoRelevanceManager } from '../utils/VideoRelevanceManager'
+
+export const commentCountersManager = new CommentCountersManager()
+export const videoRelevanceManager = new VideoRelevanceManager()
+
+videoRelevanceManager.turnOnVideoRelevanceManager()
+
+export async function recalculateAllVideosRelevance(em: EntityManager) {
+  return videoRelevanceManager.updateVideoRelevanceValue(em, true)
+}
diff --git a/src/utils/VideoRelevanceManager.ts b/src/utils/VideoRelevanceManager.ts
index feb4187bb..e1f5f3eb4 100644
--- a/src/utils/VideoRelevanceManager.ts
+++ b/src/utils/VideoRelevanceManager.ts
@@ -2,8 +2,7 @@ import { EntityManager } from 'typeorm'
 import { config, ConfigVariable } from './config'
 import { globalEm } from './globalEm'
 
-// constant used to parse seconds from creation
-export const NEWNESS_SECONDS_DIVIDER = 60 * 60 * 24
+export const SECONDS_PER_DAY = 60 * 60 * 24
 
 type VideoRelevanceManagerLoops = {
   fullUpdateLoopTime: number
@@ -67,23 +66,40 @@ export class VideoRelevanceManager {
       defaultChannelWeight,
     ] = await config.get(ConfigVariable.RelevanceWeights, em)
     const channelWeight = defaultChannelWeight ?? 1
-    const wtEpoch = `((
-          extract(epoch from video.created_at)*${joystreamTimestampWeight} +
-          COALESCE(extract(epoch from video.published_before_joystream), extract(epoch from video.created_at))*${ytTimestampWeight}
-        ) / ${joystreamTimestampWeight} + ${ytTimestampWeight})`
+    const weightedEpoch = `
+    (
+      (
+        extract(epoch from video.created_at) * ${joystreamTimestampWeight} +
+        CASE
+          WHEN (
+            video.published_before_joystream IS NOT NULL
+            AND video.published_before_joystream < now()
+          ) THEN extract(epoch from video.published_before_joystream)
+          ELSE extract(epoch from video.created_at)
+        END * ${ytTimestampWeight}
+      ) / ${joystreamTimestampWeight + ytTimestampWeight}
+    )`
+    const weightedMeanVideoAgeDays = `
+    (
+      (extract(epoch FROM now()) - ${weightedEpoch})
+      / ${SECONDS_PER_DAY}
+    )`
 
     await em.query(`
         WITH videos_with_weight AS (
           SELECT 
             video.id as videoId,
             channel.id as channelId,
-            (ROUND((
-            (extract(epoch FROM date_trunc('day', now() at time zone 'UTC')) - ${wtEpoch})
-            / ${NEWNESS_SECONDS_DIVIDER} * ${newnessWeight * -1} 
-            + (views_num * ${viewsWeight}) 
-            + (comments_count * ${commentsWeight}) 
-            + (reactions_count * ${reactionsWeight})) 
-            * COALESCE(channel.channel_weight, ${channelWeight}), 2)) as videoRelevance
+            ROUND(
+              (
+                365 * ${newnessWeight}
+                - LEAST(${weightedMeanVideoAgeDays}, 365) * ${newnessWeight}
+                + (views_num * ${viewsWeight}) 
+                + (comments_count * ${commentsWeight}) 
+                + (reactions_count * ${reactionsWeight})
+              ) * COALESCE(channel.channel_weight, ${channelWeight}),
+              2
+            ) as videoRelevance
           FROM 
             video
             INNER JOIN channel  ON video.channel_id = channel.id
@@ -129,7 +145,7 @@ export class VideoRelevanceManager {
         SET
           video_relevance = CASE
             WHEN ranked_videos.rank = 1 THEN ranked_videos.maxChannelRelevance
-            ELSE 1
+            ELSE 0
           END
         FROM
           ranked_videos
diff --git a/src/utils/notification/helpers.ts b/src/utils/notification/helpers.ts
index 738e901de..b14c57f96 100644
--- a/src/utils/notification/helpers.ts
+++ b/src/utils/notification/helpers.ts
@@ -1,8 +1,8 @@
-import { Flat } from 'lodash'
 import { EntityManager } from 'typeorm'
 import {
   Account,
   AccountNotificationPreferences,
+  Channel,
   Event,
   NextEntityId,
   Notification,
@@ -11,11 +11,12 @@ import {
   NotificationType,
   RecipientType,
   Unread,
+  Video,
 } from '../../model'
 import { getCurrentBlockHeight } from '../blockHeight'
 import { uniqueId } from '../crypto'
 import { getNextIdForEntity } from '../nextEntityId'
-import { EntityManagerOverlay } from '../overlay'
+import { EntityManagerOverlay, Flat } from '../overlay'
 
 export const RUNTIME_NOTIFICATION_ID_TAG = 'RuntimeNotification'
 export const OFFCHAIN_NOTIFICATION_ID_TAG = 'OffchainNotification'
@@ -339,3 +340,14 @@ const chunkFromEnd = (str: string, interval: number): string[] =>
   )
 const roundDecPart = (decPart: string, fractionDigits: number): string =>
   Number(`.${decPart}`).toFixed(fractionDigits).slice(1)
+
+export function parseChannelTitle(channel: Flat<Channel>): string {
+  return channel.title || FALLBACK_CHANNEL_TITLE
+}
+
+export function parseVideoTitle(video: Flat<Video>): string {
+  return video.title || FALLBACK_VIDEO_TITLE
+}
+
+export const FALLBACK_CHANNEL_TITLE = '??'
+export const FALLBACK_VIDEO_TITLE = '??'