Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnounceCandidacy validation refactor #3017

Closed
2 of 4 tasks
Tracked by #2802
WRadoslaw opened this issue May 11, 2022 · 2 comments
Closed
2 of 4 tasks
Tracked by #2802

AnnounceCandidacy validation refactor #3017

WRadoslaw opened this issue May 11, 2022 · 2 comments
Assignees
@dmtrjsg
Labels
qa-effort-30min qa-task qa-tested-ready-for-prod release:stabilisation6 scope:members The "Members" page and related features

Comments

@WRadoslaw
Copy link
Contributor

WRadoslaw commented May 11, 2022 •
edited by thesan
Loading

Refactor the AnnounceCandidacy modal as part of the #2802 epic.

Dev scope

  • Refactor fields validation
  • Manage the form state with React Hook Form instead of XState

QA scope

  • The fields are validated correctly
  • The transaction gets sent with the parameter set in the modal
@WRadoslaw WRadoslaw mentioned this issue May 11, 2022
Closed
14 tasks
@WRadoslaw WRadoslaw self-assigned this May 11, 2022
@dmtrjsg dmtrjsg added the scope:members The "Members" page and related features label May 13, 2022
@thesan thesan mentioned this issue May 16, 2022
Merged
@singulart singulart assigned dmtrjsg and unassigned WRadoslaw May 25, 2022
@singulart
Copy link
Contributor

missing description

@polikosi
Copy link
Collaborator

polikosi commented May 26, 2022 •
edited
Loading

Verified on staging.

Announce candinancy.
Screenshot_33

Candidate profile
Screenshot_34

Candidate summary
Screenshot_35

Finish
Screenshot_36
Screenshot_37
Screenshot_38

TX
Screenshot_39

https://polkadot.js.org/apps/?rpc=wss://3.235.196.1.nip.io/ws-rpc#/explorer/query/0xcebee4116b7930214b818d021416978a4ab8f4c98f72df5210f3376f25cda30d

@dmtrjsg dmtrjsg closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmtrjsg dmtrjsg

Labels
qa-effort-30min qa-task qa-tested-ready-for-prod release:stabilisation6 scope:members The "Members" page and related features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thesan @singulart @polikosi @WRadoslaw @dmtrjsg