Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forum UX Upd: duplicated component #3651

Closed
2 tasks done
Tracked by #3029
thesan opened this issue Oct 3, 2022 · 0 comments
Closed
2 tasks done
Tracked by #3029

Forum UX Upd: duplicated component #3651

thesan opened this issue Oct 3, 2022 · 0 comments
Assignees
@WRadoslaw
Labels
bug Something isn't working qa-not-required release:0.1.1 scope:forum The "Forum" page and related features

Comments

@thesan
Copy link
Collaborator

thesan commented Oct 3, 2022 •
edited
Loading

Context

Currently the codebase has 2 category cards:

  • CategoryCard: Looks good but has no props so far
  • CategoryListItem: Functional but it is missing the subcategory on hover feature. Also AFAICS the story mocks members for no reason

and 2 thread cards:

  • ThreadCard: Looks good but has no props so far
  • ThreadItem: Functional but it relies on useThreadOriginalPost internally which makes it slower and require mocks for tests/storybook. Also the some of the storybook controls don't work or are not relevant

Scope

(Part of #3029)
@thesan thesan added bug Something isn't working scope:forum The "Forum" page and related features labels Oct 3, 2022
@dmtrjsg dmtrjsg mentioned this issue Oct 11, 2022
Closed
16 tasks
@thesan thesan mentioned this issue Nov 17, 2022
Merged
@dmtrjsg dmtrjsg closed this as completed Nov 24, 2022
@thesan thesan reopened this Nov 30, 2022
@dmtrjsg dmtrjsg closed this as completed Dec 9, 2022
@traumschule traumschule mentioned this issue Dec 9, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WRadoslaw WRadoslaw

Labels
bug Something isn't working qa-not-required release:0.1.1 scope:forum The "Forum" page and related features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thesan @WRadoslaw @dmtrjsg