-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement markers #6
Comments
@Jpadilla1 I try to integrate this smart native chart lib but failed, I ever post issue here and feeling excited that you bring it to react native. I asked developer who say the BallonMaker be implemented in thanks for your time :) regards. |
I did a interesting progress on it. @L-Jovi Is your problem on stackoverflow related to BalloonMarker directly? I think support BallonMarker at this stage would be a good way to started, I tried to work with RadarMarkerView as well, but it a different design from BalloonMarker, they started it on a new marker protocol. probably for the next version, which i didn't had a chance to try with this react-native-ios-charts. So i basically took the BalloonMarker from this commit and added the textColor property and instantiated it on CharViewBaseExtension.swift, and add some javascript props. const config = {
drawMarkers: true,
marker: {
markerColor: 'red',
markerTextColor: 'black',
markerFontName: 'SomeFont'
markerFontSize: 14,
},
} @Jpadilla1 Any thoughts and feedbacks before i can pull request? |
Hi @cesardeazevedo that looks awesome!!! Would love a pull request :) |
Cool, i'll send soon. |
@cesardeazevedo cool! |
No description provided.
The text was updated successfully, but these errors were encountered: