diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d88915a..c32a3e51 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,16 @@ # Change Log All notable changes to this project will be documented in this file +## [Typo (1.2.3)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.3) + +### Fixes + +- Fix typo in `SkeletonTableViewDataSource` protocol + +### Improvements + +- Now it takes in account the `UIStackView` to calculate the `SkeletonLayer` bounds (thanks @giantramen) + ## [New face (1.2.2)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.2) ### New @@ -8,7 +18,7 @@ All notable changes to this project will be documented in this file - Rebranding ### Bug fixes -- Solved issue [#23](https://github.com/Juanpe/SkeletonView/issues/23). Problem with UIStackView . (thanks @giantramen ) +- Solved issue [#23](https://github.com/Juanpe/SkeletonView/issues/23). Problem with UIStackView. (thanks @giantramen) ## [State (1.2.1)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.1) diff --git a/README.md b/README.md index 70ae1b53..2182ee02 100755 --- a/README.md +++ b/README.md @@ -171,7 +171,7 @@ If you want to show the skeleton in a ```UITableView```, you need to conform to public protocol SkeletonTableViewDataSource: UITableViewDataSource { func numSections(in collectionSkeletonView: UITableView) -> Int func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int - func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier + func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier } ``` As you can see, this protocol inherits from ```UITableViewDataSource```, so you can replace this protocol with the skeleton protocol. @@ -191,12 +191,12 @@ func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection s There is only one method you need to implement to let Skeleton know the cell identifier. This method doesn't have default implementation: ``` swift - func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier + func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier ``` **Example** ``` swift - func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier { + func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier { return "CellIdentifier" } ```