Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing animation can not render UIView's border? #232

Closed
iWECon opened this issue Jan 2, 2020 · 5 comments
Closed

Showing animation can not render UIView's border? #232

iWECon opened this issue Jan 2, 2020 · 5 comments

Comments

@iWECon
Copy link

iWECon commented Jan 2, 2020

What did you do?

I have a View with Border.

What did you expect to happen?

The Border always not be rendered when startGradientAnimation.

Steps to reproduce the behavior

Create a UIView, and set borderColor, borderWith, borderOpacity, then use SkeletonView's showGradientAnimation show it.
The view's border is not hidden or render.

SkeletonView Environment

SkeletonView version: 1.8.2
Xcode version: 11.3
Swift version: 5

@iWECon
Copy link
Author

iWECon commented Jan 2, 2020

I checked SkeletonView's APIs, it contains SkeletonFlowDelegate.
The delegate's two methods that can help me resolve this problem, but it's not Public.

@iWECon
Copy link
Author

iWECon commented Jan 2, 2020

I want to hide border use willBeginShowingSkeletons(rootView:), and show border use willBeginHidingSkeletons(rootView: UIView).

@iWECon
Copy link
Author

iWECon commented Jan 2, 2020

image

The screenshot contains two UIView with border.
I think it is a bug.

@iWECon
Copy link
Author

iWECon commented Jan 2, 2020

image

Now, I find the RecoverableViewState, maybe you can add a line code with self.layer.borderWidth or self.layer.borderColor.

@iWECon iWECon changed the title Why SkeletonFlowDelegate is not public? Showing animation can not render UIView's border? Jan 2, 2020
@Juanpe
Copy link
Owner

Juanpe commented Feb 12, 2020

Hi @iWECon, SkeletonView now has notifications using NotificationCenter. This change was included in version 1.8.5 (PR #227).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants