-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization of scitypes in source code #21
Comments
Thanks for the offer to help out.
@OkonSamuel is this likely to cause merge conflict pain with the PR's you are working on? To be honest, more helpful would be to improve the organization of /test at ScientificTypes, but that's not going to be much fun 😉 |
@OkonSamuel please let me know if I can cleanup the house in the main source file. The plan is to just move things around in a first PR, and then reassess the code. |
I'll open a PR this weekend so we can discuss and move things around. Am currently working on improving performance. |
Hi @OkonSamuel , any update on this issue? I am working actively in a project where scientific types will be first-class and would like to contribute to this code more actively. Please let me know when I can start working on a PR. |
Am sorry @juliohm I have been busy lately. You can go ahead and open a PR. |
After #20 is reviewed, can I help reorganizing the types in the source code? I find the scitype section a bit confusing to read. I would like to struct it as a tree of types so that readers can follow the type hierarchy more easily. Also, I could take this opportunity to deprecate some old types like Scientific from the source.
Please let me know if that would be helpful. I plan to work more closely with ScientificTypes.jl moving forward as well.
cc: @ablaom
The text was updated successfully, but these errors were encountered: