Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BandedMatrices extension #315

Open
dlfivefifty opened this issue Oct 10, 2023 · 5 comments
Open

Add BandedMatrices extension #315

dlfivefifty opened this issue Oct 10, 2023 · 5 comments

Comments

@dlfivefifty
Copy link
Member

I wanted to move some of the features from BlockBandedMatrices.jl to an extension.

this would require making this package dependent on BandedMatrices for <v1.9. Any objections?
@jishnub
Copy link
Member

jishnub commented Oct 12, 2023

I guess the main concern is the increase in package load time on v1.6, but seems ok to me

@dlfivefifty
Copy link
Member Author

Do we care about Julia v1.6 users? Do they exist? If it were just up to me I'd actually just drop <v1.9...

@jishnub
Copy link
Member

jishnub commented Oct 14, 2023

I would think that users of v1.6 likely pin their dependency versions as well to ensure reproducibility, so this change shouldn't impact such users at all. In any case, given that v1.10 is coming soon and might become the LTS in around six months, perhaps we're not going to support v1.6 for much longer. This change therefore seems fine to me

@jishnub
Copy link
Member

jishnub commented Mar 20, 2024

Given that v1.10 is rapidly approaching the LTS status, perhaps it's time this is implemented.

@dlfivefifty
Copy link
Member Author

I started it but got distracted… I can look again now that lectures are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlfivefifty @jishnub