Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tril/triu for ZerosMatrix and OneElementMatrix #334

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 22, 2023

With this, tril/triu are no-ops for a ZerosMatrix, and O(1) for a OneElementMatrix

julia> @btime triu($(Ref(Zeros(100,100)))[]);
  2.019 μs (0 allocations: 0 bytes) # master
  2.945 ns (0 allocations: 0 bytes) # PR

julia> @btime triu($(Ref(OneElement(3, (100,100), (100,100))))[]);
  25.277 μs (2 allocations: 78.17 KiB) # master
  3.780 ns (0 allocations: 0 bytes) # PR

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (545fa12) to head (93edb5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1055     1063    +8     
=======================================
+ Hits         1054     1062    +8     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub requested a review from dlfivefifty May 4, 2024 16:44
@jishnub
Copy link
Member Author

jishnub commented Jul 8, 2024

Gentle bump

@dlfivefifty dlfivefifty merged commit 4bfbeec into master Jul 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants