Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-place versions for matrix operations when using mutable static arrays #1054

Open
aplesner opened this issue Jul 7, 2022 · 1 comment
Open

In-place versions for matrix operations when using mutable static arrays #1054

aplesner opened this issue Jul 7, 2022 · 1 comment
Labels
feature features and feature requests

Comments

@aplesner
Copy link

aplesner commented Jul 7, 2022

There are currently no in-place implementations for lu factorization and ldiv when using mutable matrices/vectors (MMatrix and MVector). This currently causes errors when using a stiff ODE solvers with the state being an MVector.

This may be related to issue #1031.
@mateuszbaran mateuszbaran added the feature features and feature requests label Jul 7, 2022
@j-fu
Copy link

j-fu commented Apr 19, 2023

I am missing this as well so I am dabbling with my own codes on need.

That code also should work with StrideArrays etc. Being non-allocating IMHO is a must, so there should be a e.g. LU factorization where one can pass ipiv.

BTW, in 1.9

ldiv!(b, RecursiveFactorization.lu!(A, ipiv, Val(true), Val(false)), b)

works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature features and feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mateuszbaran @j-fu @aplesner