Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated action versions #125

Closed
wants to merge 5 commits into from
Closed

Update outdated action versions #125

wants to merge 5 commits into from

Conversation

gnadt
Copy link

@gnadt gnadt commented Apr 16, 2024

@bramtayl
Copy link
Member

Ok as long as you've verified that you can still use ALSA plugins with this change. I'm a little unsure whether modifying the environment will work as part of the module, seems a bit safer to do during initialization? Maybe make ALSA_PLUGIN_DIR const since it's now a global variable? Why do you need it to be available during precompilation?

@gnadt gnadt changed the title Update outdated action versions & move ALSA_PLUGIN_DIR env variable Update outdated action versions Apr 17, 2024
@gnadt
Copy link
Author

gnadt commented Apr 17, 2024

On Linux, no the ALSA plugins can't be used. I don't think they could before either, but there are no CI results to look at. That change didn't resolve the issue, I've tried a bunch of things in my fork, nothing seems to get PortAudio to precompile on Linux. Potentially some issue with using dlopen on the ALSA plugin library files, but I'm not familiar with that.

@bramtayl
Copy link
Member

Last time I checked the alsa plugins bit was working? If that particular change doesn't help precompilation, I'd say we shouldn't do it.

@gnadt
Copy link
Author

gnadt commented Apr 17, 2024

On Linux it was working? If so, please re-run the Tests workflow without any changes so there's a baseline

@gnadt gnadt closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants