Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put unit exports behind a submodule? #36

Open
ssfrr opened this issue Apr 6, 2018 · 1 comment
Open

Put unit exports behind a submodule? #36

ssfrr opened this issue Apr 6, 2018 · 1 comment
Milestone

Comments

@ssfrr
Copy link
Collaborator

ssfrr commented Apr 6, 2018

It seems a little rude perhaps to export 1-letter names like s to the users namespace without asking (particularly if they're running mostly unitless), so I'm wondering whether it's better to force an explicit using SampledSignals.Units if you want to use the short unit exports.

I figure that there are going to be some breaking changes coming up, so now would be a good time to make this change.

@haberdashPI do you think that's reasonable or just adds inconvenience for users?

@haberdashPI
Copy link
Contributor

I somehow missed this. That seems completely reasonable to me! I've wondered that myself.

@ssfrr ssfrr added this to the v3.0 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants