Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage fails on travis Ci with julia nightly #227

Closed
philoez98 opened this issue Jun 26, 2019 · 6 comments
Closed

Coverage fails on travis Ci with julia nightly #227

philoez98 opened this issue Jun 26, 2019 · 6 comments

Comments

@philoez98
Copy link

Hello, while trying to build with travis and Julia nightly it fails with this stacktrace:

ERROR: type Regex has no field match_data
Stacktrace:
 [1] getproperty(::Any, ::Symbol) at ./Base.jl:20
 [2] exec(::Regex, ::String, ::Int64) at /home/travis/.julia/packages/HTTP/GN0Te/src/parseutils.jl:4 (repeats 2 times)
 [3] #parse_uri_reference#6(::Bool, ::typeof(HTTP.URIs.parse_uri_reference), ::String) at /home/travis/.julia/packages/HTTP/GN0Te/src/URIs.jl:129
 [4] parse_uri_reference(::String) at /home/travis/.julia/packages/HTTP/GN0Te/src/URIs.jl:129
 [5] HTTP.URIs.URI(::String) at /home/travis/.julia/packages/HTTP/GN0Te/src/URIs.jl:150
 [6] #request#6(::Array{Pair{SubString{String},SubString{String}},1}, ::HTTP.Form, ::Nothing, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(HTTP.request), ::String, ::String, ::Array{Pair{SubString{String},SubString{String}},1}, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/HTTP.jl:310
 [7] request(::String, ::String, ::Array{Pair{SubString{String},SubString{String}},1}, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/HTTP.jl:310
 [8] #post#4(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(HTTP.post), ::String, ::Array{Pair{SubString{String},SubString{String}},1}, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/multipart.jl:132
 [9] post(::String, ::Array{Pair{SubString{String},SubString{String}},1}, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/multipart.jl:131
 [10] #post#3(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(HTTP.post), ::String, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/multipart.jl:128
 [11] post(::String, ::HTTP.Form) at /home/travis/.julia/packages/HTTP/GN0Te/src/multipart.jl:128
 [12] post_request(::Dict{String,Any}, ::Bool) at /home/travis/.julia/packages/Coverage/c1tw7/src/coveralls.jl:180
 [13] #submit#1(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(Coverage.Coveralls.submit), ::Array{FileCoverage,1}) at /home/travis/.julia/packages/Coverage/c1tw7/src/coveralls.jl:67
 [14] submit(::Array{FileCoverage,1}) at /home/travis/.julia/packages/Coverage/c1tw7/src/coveralls.jl:59
 [15] top-level scope at none:1
The command "julia --color=yes -e "if VERSION < v\"0.7.0-DEV.5183\"; cd(Pkg.dir(\"${JL_PKG}\")); else using Pkg; end; Pkg.add(\"Coverage\"); using Coverage; Coveralls.submit(process_folder())"" exited with 1.

I know that Julia nightly is not supported yet, but maybe this will give some insight on the problem.

@ronisbr
Copy link

ronisbr commented Jun 26, 2019

In my case, it is working with macOS but not with Linux. However, the macOS commit (f6049d6d25) is behind the Linux one (d95841934a). Thus, comparing them, this bug was created by this commit:

JuliaLang/julia@cef655a

which removed the match_data field from Regex.

@philoez98
Copy link
Author

philoez98 commented Jun 26, 2019

@ronisbr thanks! I forgot to specify, this happens on Linux.

@philoez98
Copy link
Author

As of today it fails also with macOS with the same error.

@fingolfin
Copy link
Member

Please provide a link to a Travis log highlighting the failure.

Note that Coverage.jl does not use match_data itself, so whatever this is, it seems unlikely to be caused by Coverage.jl.

@fingolfin
Copy link
Member

Aha, it is in HTTP.jl, which Coverage.jl uses, see here: JuliaWeb/HTTP.jl#430

@philoez98
Copy link
Author

HTTP.jl fixed the problem on their part and now Coverage.jl works as expected on every platform. I'm closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants