Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better github action support? #284

Closed
kyungminlee opened this issue Sep 29, 2020 · 1 comment · Fixed by #288
Closed

better github action support? #284

kyungminlee opened this issue Sep 29, 2020 · 1 comment · Fixed by #288

Comments

@kyungminlee
Copy link
Contributor

add_ci_to_kwargs from codecovio.jl can be updated to provide better support for GitHub Action. Current version ignores branch when submitting to CodeCov.

elseif haskey(ENV, "GITHUB_ACTION") # GitHub Actions
kwargs = set_defaults(kwargs,
service = "custom",
commit = ENV["GITHUB_SHA"],
slug = ENV["GITHUB_REPOSITORY"],
)

@fingolfin
Copy link
Member

Unfortunately nobody is really working on Coverage.jl right now. If you have an inkling of what needs to be done here (e.g. how to figure out the correct branch and how to submit it), perhaps consider submitting a PR to Coverage.jl to get it done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants