Add pull request number to Coveralls.io #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
+ Coverage 90.11% 90.22% +0.11%
==========================================
Files 6 6
Lines 344 348 +4
==========================================
+ Hits 310 314 +4
Misses 34 34
Continue to review full report at Codecov.
|
|
I can't really tell what Coveralls.io does with this to know that it's correct (I suspect it's been inferring the same information successfully), but should be good to go. Will merge in a bit, unless someone chimes in that they wanted to review first. |
DilumAluthge
approved these changes
Nov 25, 2019
fingolfin
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send it to CodeCov.io, so just copying it over to Coveralls.