-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run only a subset of tests on PRs that only modify the manual #243
Comments
And PRs editing only the readme shouldn't run anything |
Cross-ref JuliaLang/julia#45744 |
I think the way to do this is to have a "filter" that looks at the diff, and skips launching a job if the diff does not contain changes to a particular group of files. We can also construct this negatively, e.g. filter out elements of a diff, and then run if any diff remains. The way I'm imagining this is to write a buildkite plugin that does something like the following:
|
In Yggdrasil we collect the files modified in a PR/commit: https://github.com/JuliaPackaging/Yggdrasil/blob/fb8152880d5bb011c4ab2a23b84fff2327c1ee17/azure-pipelines.yml#L81-L86. Valentin will have done something similar with buildkite in JuliaPackaging/Yggdrasil#4771 |
I put together a plugin based on @staticfloat idea: https://github.com/fatteneder/diff-filter-buildkite-plugin It seems to work fine in my tests: https://buildkite.com/testingplugin/bash-example/builds/63#0192d94f-a732-4f76-bb12-ad2262b75cc9 How would I go about testing it with the Julia repo? |
I get "page not found"
Think so. |
My bad, pipeline was private, should work now. |
If a PR only modifies the manual, then we only need to run a subset of jobs, including:
The text was updated successfully, but these errors were encountered: