Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between v34 and v36 ngspice_jll #33

Open
sjkelly opened this issue May 5, 2022 · 2 comments
Open

Differences between v34 and v36 ngspice_jll #33

sjkelly opened this issue May 5, 2022 · 2 comments

Comments

@sjkelly
Copy link

sjkelly commented May 5, 2022

On this test:

for branch in split("vcc#branch vin#branch")
@test getvec(branch)[2] == "current"
end

(note: I added listallvecs() for debugging)

with v36:

     Testing Running tests...
Test Summary:       | Pass  Total
interface functions |    6      6
Running the simulator
listallvecs() = Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"])
getvectors: Error During Test at /home/steve/.julia/dev/NgSpice/test/wrapper_api.jl:27
  Test threw exception
  Expression: (getvec(branch))[2] == "current"
  "Vector vin#branch not found"
  Stacktrace:

with v34:

listallvecs() = Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"])

I am not certain if an API has changed, but we should likely pin ngspice_jll at v34 for the time being since the tests fail.

cc @GlenHertz

@sjkelly
Copy link
Author

sjkelly commented May 5, 2022

Related? imr/ngspice@951be0d

@ven-k
Copy link
Member

ven-k commented Jun 6, 2022

With v37

@info listallvecs()
[ Info: Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["coll", "base", "V(1)", "vcc", "emit", "time"])

Both vcc#branch and vin#branch are missing from all-vectors-list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants