Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SymPy.jl #21

Open
ufechner7 opened this issue Oct 10, 2023 · 6 comments
Open

Remove dependency on SymPy.jl #21

ufechner7 opened this issue Oct 10, 2023 · 6 comments

Comments

@ufechner7
Copy link

For me SymPy.jl fails to compile on 2 of 3 PCs. Second best option would be https://github.com/jverzani/SymPyPythonCall.jl/, best option not being dependent on Python.

@baggepinnen
Copy link
Member

SymPy is a fundamental core dependency of this package and this will not be changed

@ufechner7
Copy link
Author

ufechner7 commented Oct 11, 2023

First question: Which feature does SymPy.jl provide that SymPyPythonCall.jl doesn't provide?

Second question: Which features are missing in Symbolics.jl for implementing the conversion of a symbolic s expression into a transfer function?

@baggepinnen
Copy link
Member

Which feature does SymPy.jl provide that SymPyPythonCall.jl doesn't provide?

I don't know, and since this package is working perfectly fine on my machine and on the CI runner, I cannot motivate spending time figuring it out.

Which features are missing in Symbolics.jl for implementing the conversion of a symbolic s expression into a transfer function?

I don't know, Symbolics is missing a lot of features, like documentation, stability and maturity.

@ufechner7
Copy link
Author

https://github.com/JuliaPy/PythonCall.jl is the future...

@ufechner7
Copy link
Author

I cannot motivate spending time figuring it out.

The question is, would you accept a pull request that replaces PyCall with PythonCall?

@baggepinnen
Copy link
Member

I have nothing against switching, I just cannot motivate spending time on it. If you submit a PR that makes the change (and that change alone), that'd be fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants