change tests, fix compat with 1.6 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed to test on v1.6, v1, nightly - test on windows-latest and ubuntu-latest instead of macos
- split into `_levinson_small`, `..._large`, but large is always faster on my machine for all `p` - noticed v from _large and _small are different, checked that v (or e) for 1 signal is not a vector from broadcasting but complex `dot`
- benchmarked to be always slower than the O(n^2) version (p=8) on my machine
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 92.23% 92.33% +0.10%
==========================================
Files 5 5
Lines 502 496 -6
==========================================
- Hits 463 458 -5
+ Misses 39 38 -1 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7097375215
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple_dotfor 1.6 compat because of old BLAS bug