Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #1119

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix typos #1119

merged 1 commit into from
Dec 15, 2023

Conversation

musvaage
Copy link
Contributor

Should the comment read The or These?

$ ed -s CSV.jl/src/file.jl <<<'567,575p'
        if !ctx.threaded && ctx.ntasks > 1 && !ctx.silencewarnings
            # !ctx.threaded && ctx.ntasks > 1 indicate that multithreaded parsing failed.
            # Thes messages echo the corresponding debug statement in the definition of ctx
            if numwarnings[] > 0
                @warn "Multithreaded parsing failed and fell back to single-threaded parsing, check previous warnings for possible reasons."
            else
                @error "Multithreaded parsing failed and fell back to single-threaded parsing. This can happen if the input contains multi-line fields; otherwise, please report this issue."
            end
        end
$ 

This looks like it should read partition.

$ ed -s CSV.jl/test/write.jl <<<'345,350p'
    # parition writing
    io = IOBuffer()
    io2 = IOBuffer()
    CSV.write([io, io2], Tables.partitioner((default_table, default_table)); partition=true)
    @test String(take!(io)) == "col1,col2,col3\n1,4,7\n2,5,8\n3,6,9\n"
    @test String(take!(io2)) == "col1,col2,col3\n1,4,7\n2,5,8\n3,6,9\n"
$

@nickrobinson251

What is a cscv file?

$ find CSV.jl/test/testfiles -type f | grep -oE '\.(\w+)$' | sort -u
.cscv
.csv
.dat
.gz
.tsv
.txt
.wsv
$ 

@musvaage musvaage marked this pull request as draft December 10, 2023 17:49
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb1b411) 90.45% compared to head (32c7de7) 90.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   90.45%   90.45%   -0.01%     
==========================================
  Files           9        9              
  Lines        2305     2304       -1     
==========================================
- Hits         2085     2084       -1     
  Misses        220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @musvaage!

@quinnj
Copy link
Member

quinnj commented Dec 15, 2023

Should the comment read The or These?

These.

This looks like it should read partition.

Correct.

I think .cscv is just a mistake and can be fixed. Thanks!

@musvaage
Copy link
Contributor Author

I think .cscv is just a mistake and can be fixed.

The cscv file appears to be a duplicate so it was removed.

$ diff test/testfiles/test_one_row_of_data.cscv \
> test/testfiles/test_one_row_of_data.csv
$ 

@musvaage musvaage marked this pull request as ready for review December 15, 2023 15:59
@quinnj quinnj merged commit c6efb45 into JuliaData:main Dec 15, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants