From 55ecb4c6343542623d37ec1fbab8a04a289a3a3e Mon Sep 17 00:00:00 2001 From: rofinn Date: Fri, 18 Aug 2017 16:34:46 -0500 Subject: [PATCH] Removed `test/conversions.jl` version check. --- test/conversions.jl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/conversions.jl b/test/conversions.jl index 3f86249bde..6109bf7f90 100644 --- a/test/conversions.jl +++ b/test/conversions.jl @@ -13,10 +13,8 @@ module TestConversions df = DataFrame() df[:A] = 1:5 df[:B] = 1.0:5.0 - # Fails on Julia 0.4 since promote_type(Nullable{Int}, Nullable{Float64}) gives Nullable{T} - if VERSION >= v"0.5.0-dev" - @test isa(convert(Array, df), Matrix{Float64}) - end + @test isa(convert(Array, df), Matrix{Float64}) + @test convert(Array, df) == convert(Array, convert(NullableArray, df)) @test isa(convert(Array{Any}, df), Matrix{Any}) @test isa(convert(Array{Float64}, df), Matrix{Float64})