From 97bbb40a9aa74a1517a420c0f906cb5b98d8cff3 Mon Sep 17 00:00:00 2001 From: sprig Date: Sat, 7 Sep 2024 03:38:25 -0700 Subject: [PATCH] Update filter docs, Fixes #3460 (#3461) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update filter docs * Apply suggestions from code review --------- Co-authored-by: Bogumił Kamiński --- src/abstractdataframe/abstractdataframe.jl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/abstractdataframe/abstractdataframe.jl b/src/abstractdataframe/abstractdataframe.jl index e8f4e32ed..f549a07e8 100644 --- a/src/abstractdataframe/abstractdataframe.jl +++ b/src/abstractdataframe/abstractdataframe.jl @@ -1151,6 +1151,11 @@ data frames. function instead as it is consistent with other DataFrames.jl functions (as opposed to `filter`). +!!! note + + Due to type stability the `filter(cols => fun, df::AbstractDataFrame; view::Bool=false)` + call is preferred in performance critical applications. + $METADATA_FIXED See also: [`filter!`](@ref) @@ -1281,6 +1286,11 @@ data frames. function instead as it is consistent with other DataFrames.jl functions (as opposed to `filter!`). +!!! note + + Due to type stability the `filter!(cols => fun, df::AbstractDataFrame)` + call is preferred in performance critical applications. + $METADATA_FIXED See also: [`filter`](@ref)