Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append! broken with PooledArray column type #1816

Closed
tk3369 opened this issue May 22, 2019 · 2 comments
Closed

append! broken with PooledArray column type #1816

tk3369 opened this issue May 22, 2019 · 2 comments

Comments

@tk3369
Copy link
Contributor

tk3369 commented May 22, 2019

The latest CSV package uses PooledArrays but it doesn't work well with DataFrames.

julia> df = CSV.File(download("https://gist.githubusercontent.com/tk3369/9a005ffbf5f1bf7648cb4558f72e66e7/raw/5a6b6a8d6a4e69fca6fe788d87ddd55f6498af25/test.csv")) |> DataFrame;

julia> df2 = deepcopy(df);

julia> append!(df, df2)
ERROR: MethodError: no method matching append!(::PooledArrays.PooledArray{String,UInt32,1,Array{UInt32,1}}, ::PooledArrays.PooledArray{String,UInt32,1,Array{UInt32,1}})
Closest candidates are:
  append!(::DataFrame, ::Any) at C:\Users\tkwong\.julia\packages\DataFrames\m9gd9\src\other\tables.jl:39
  append!(::Array{#s72,1} where #s72, ::AbstractArray{T,1} where T) at array.jl:893
  append!(::Array{T,1} where T, ::Any) at array.jl:900
  ...
@bkamins
Copy link
Member

bkamins commented May 22, 2019

Thank you for reporting this. There is an issue opened to fix it here JuliaData/PooledArrays.jl#23.

@nalimilan
Copy link
Member

Closing since that's not a bug in DataFrames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants