Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permutedims with CategoricalArray #3003

Closed
bkamins opened this issue Feb 15, 2022 · 4 comments · Fixed by #3004
Closed

permutedims with CategoricalArray #3003

bkamins opened this issue Feb 15, 2022 · 4 comments · Fixed by #3004
Labels
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Feb 15, 2022

@nalimilan - currently in

eltype(df[!, src_namescol]) <: SymbolOrString ||

we allow column that is to be converted to column names to be only string or Symbol. This is, in particular, problematic with CategoricalArrays.jl.

What do you think we should do with it? Should we just automatically convert any non-string or symbol value to string or e.g. add strict::Bool=true kwarg, which by default is the current behavior, but if strict=false we perform conversion to string?

@bkamins bkamins added this to the 1.4 milestone Feb 15, 2022
@nalimilan
Copy link
Member

Maybe we could first try converting to string, as that's quite safe? Then if users pass strict=false we could call string on the values, which would be more risky to do by default.

@bkamins
Copy link
Member Author

bkamins commented Feb 15, 2022

you mean in try-catch or checking if eltype can be converted to String?

@nalimilan
Copy link
Member

try... catch. Detecting conversion from the eltype is difficult or impossible.

@bkamins
Copy link
Member Author

bkamins commented Feb 15, 2022

I agree, that is why I asked 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants