Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance of dropmissing #3254

Closed
bkamins opened this issue Dec 23, 2022 · 0 comments · Fixed by #3256
Closed

improve performance of dropmissing #3254

bkamins opened this issue Dec 23, 2022 · 0 comments · Fixed by #3256
Labels
performance
Milestone
patch

Comments

@bkamins
Copy link
Member

bkamins commented Dec 23, 2022

When disallowmissing=true we do two operations in dropmissing:

  1. remove rows with missing.
  2. do type conversion

It should be possible to do both steps in one shot to improve performance (by pre-allocating undef columns and filling them).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
patch
Development

Successfully merging a pull request may close this issue.

Improve performance of dropmissing svilupp/DataFrames.jl
1 participant
@bkamins