do not pass empty vector to Tables.columntable #3435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nalimilan - following your comment on Slack this is a DataFrames.jl fix. In it I propose even more extreme approach - do not generate any columns if the returned vector is empty. This will make consistent behavior of
DataFrame
, andGroupedDataFrame
, as it is now a corner case when they differ.The behavior before this PR is:
TODO: tests/news - after we decide what we want