add cols to mapcols and mapcols! #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan - do you know why DataFrames.jl tests on nightly keep failing? I though that |
nalimilan
reviewed
Oct 14, 2023
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
reviewed
Oct 15, 2023
src/abstractdataframe/iteration.jl
Outdated
| else | ||
| picked = Set(names(df, cols)) | ||
| apply = Bool[name in picked for name in names(df)] | ||
| @assert length(apply) == ncol(df) |
There was a problem hiding this comment.
Any reason why this could be false?
There was a problem hiding this comment.
No - it is just that later we use zip which does not check this invariant.
If you prefer I can remove it.
There was a problem hiding this comment.
Well it seems to me that the comprehension that creates apply already guarantees that invariant (unless names is broken but then we have more serious problems...).
There was a problem hiding this comment.
OK - I removed the @assert
nalimilan
approved these changes
Oct 17, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
colskwarg tomapcolsandmapcols!similarly like we recently did for column renaming.This is a useful addition for cases when e.g. one wants to transform only columns meeting some condition and keep the column order unchanged.