Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add findcols #3389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add findcols #3389

wants to merge 3 commits into from

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Oct 18, 2023

Fixes #3235

If we decide to add it in the next PR I would add #2508

@bkamins bkamins requested a review from nalimilan October 18, 2023 09:07
@bkamins bkamins added this to the 1.7 milestone Oct 18, 2023
@bkamins
Copy link
Member Author

bkamins commented Oct 18, 2023

@nalimilan - the rationale behind adding it is to make it more obvious for users how to select columns by condition by their contents. Currently users need to use e.g. comprehension or findall on eachcol and newcomers do not find it obvious.

@nalimilan
Copy link
Member

Sorry for the delay. I'm not totally convinced that this is needed. Is it really so important to save a few characters?

Also, the existing *cols functions have equivalents without the "cols" suffix which operate on rows, and this isn't the case here. Do we want to define findall to operate on rows (and in that case maybe have findallcols instead of findcols)?

@bkamins
Copy link
Member Author

bkamins commented Nov 7, 2023

I had similar thoughts. The major question is if we want it (naming decision can come next).
Also, related is if we want filtercols function as discussed in #2508.

The options are:

  1. do not add anything;
  2. add only column filtering (which extends filter following the rules you described with filtercols naming).
  3. add column filtering and a helper findcols function (possibly with a different name).

All these functions are convenience, so I would be OK not to add anything, but I wanted to discuss this, as I see that newcomers might find it easier if such functions were available.

@bkamins bkamins modified the milestones: 1.7, 1.x Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add findcols
2 participants