Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nonunique bug #3393

Merged
merged 3 commits into from
Oct 21, 2023
Merged

fix nonunique bug #3393

merged 3 commits into from
Oct 21, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Oct 20, 2023

fixes #3392

reproducer:

julia> nonunique(DataFrame(a=PooledArray(Int[])))
ERROR: InexactError: trunc(Int64, NaN)

@bkamins bkamins requested a review from nalimilan October 20, 2023 09:45
@bkamins bkamins added the bug label Oct 20, 2023
@bkamins bkamins added this to the 1.7 milestone Oct 20, 2023
@bkamins bkamins mentioned this pull request Oct 20, 2023
Closed
@bkamins bkamins merged commit 831f010 into main Oct 21, 2023
5 of 7 checks passed
@bkamins bkamins deleted the bk/nonunique_bug branch October 21, 2023 17:29
@bkamins
Copy link
Member Author

bkamins commented Oct 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

error when unique! a empty dataframe
2 participants
@bkamins @nalimilan