Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new Julia v1.2 compatible version of TypedTables #52

Open
oschulz opened this issue Jun 17, 2019 · 12 comments
Open

Register new Julia v1.2 compatible version of TypedTables #52

oschulz opened this issue Jun 17, 2019 · 12 comments

Comments

@oschulz
Copy link
Contributor

oschulz commented Jun 17, 2019

The current version of TypedTables in the Julia registry (v1.1.0) hangs on Julia v1.2. Could we register the current master (resp. commit 59773eb) via @JuliaRegistrator register?

@oschulz
Copy link
Contributor Author

oschulz commented Jun 19, 2019

Hey @andyferris , sorry for nagging you about this. I'm just in a bit of a bind with TypedTables not running on Julia 1.2, because it currently blocks Travis/Appveyor testing for several of my packages on 1.2, and blocks BAT.jl completely (BAT.jl ran on Julia 1.0 and 1.1, but 1.0.1 and 1.1.1 kinda broke it, so since the release of those it really needs 1.2-rc because that fixes Julia issue #31666).

If Registrator is active on TypedTables, a commit comment @JuliaRegistrator register on
59773eb
should be enough (assuming I did everything right in Project.toml).

@samusz
Copy link

samusz commented Jun 21, 2019

Hi @andyferris
I believe I have the same problem : j've added TypedTables in v1.2 and precompilation takes for ever, never to completion or error message (and still using about 25% memory so seems alive).
I don't know what to do to you help fix this, but if you have some pointers I might try and give it a go.
Thanks

The backtrace shows up when I kill the precompile with C-c :
(this is on Win10)

using TypedTables
[ Info: Precompiling TypedTables [9d95f2ec-7b3d-5a63-8d20-e2491e220bb9]
ERROR: InterruptException:
Stacktrace:
[1] poptaskref(::Base.InvasiveLinkedListSynchronized{Task}) at .\task.jl:564
[2] wait() at .\task.jl:591
[3] wait(::Base.GenericCondition{Base.AlwaysLockedST}) at .\condition.jl:104
[4] stream_wait(::Base.Process, ::Base.GenericCondition{Base.AlwaysLockedST}) at .\stream.jl:47
[5] wait at .\process.jl:956 [inlined]
[6] success at .\process.jl:771 [inlined]
[7] compilecache(::Base.PkgId, ::String) at .\loading.jl:1245
[8] _require(::Base.PkgId) at .\loading.jl:1013
[9] require(::Base.PkgId) at .\loading.jl:911
[10] require(::Module, ::Symbol) at .\loading.jl:906

@oschulz
Copy link
Contributor Author

oschulz commented Jun 24, 2019

Gentle bump @andyferris . We'd like to do a new release of BAT.jl, but it won't install without a new Julia-v1.2-compatible release of TypedTables. I'm really sorry to bother you, Andy, I can imagine that you're very busy with JuliaCon coming up ... but if you could find a moment to trigger Registrator, I'd be very grateful!

@andyferris
Copy link
Member

Hmm - sorry for being unresponsive - I’m currently in the middle of a four week tour of central Australia. Not much internet and even less computers.

I’ve also haven’t used Registrator yet... let’s see how I can help.

@andyferris
Copy link
Member

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/1547

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v1.2.0 -m "<description of version>" fc1247a590be301341d172d447f706347bed727e
git push origin v1.2.0

@andyferris
Copy link
Member

Ok so I installed Registrator and Tagbot. Does anyone know what happens with github releases and github docs?

@oschulz
Copy link
Contributor Author

oschulz commented Jun 24, 2019

Hmm - sorry for being unresponsive - I’m currently in the middle of a four week tour of central Australia.

Sorry for disturbing your trip!

@oschulz
Copy link
Contributor Author

oschulz commented Jun 24, 2019

Ok so I installed Registrator and Tagbot. Does anyone know what happens with github releases and github docs?

Tagbot should take care of creating the GitHub release - though in this cases, I don't know what'll happen, since you created the release manually already a while back.

Documenter docs generation seemed unaffected by the switch to Registrator, with my packages.

@andyferris
Copy link
Member

No worries, @oschulz. Luckily you got me at a moment where I have 4G coverage, a charged phone and no children nagging me (probably the first such concurrence for a week ;) ).

And yeah, unfortunately I won’t be making JuliaCon this year but if you are going - have fun!

@oschulz
Copy link
Contributor Author

oschulz commented Jun 25, 2019

Luckily you got me at a moment where I have 4G coverage, a charged phone and no children nagging me

I can imagine, @andyferris ! :-) Have lot's of fun, down under!

@oschulz
Copy link
Contributor Author

oschulz commented Jun 28, 2019

Registration of v1.2 went trough fine, thanks again!

TagBot failed, the version that was registered is one commit ahead (I think) of your manual 1.2 release. @andyferris, at some point, when you have a network connection again, you may want to delete your manual release, and trigger TagBot again (see bottom of JuliaRegistries/General#1547. It's not time critical at all though, of course.

It's more of a cosmetic/consistency thing, of course - I'll just leave this issue open so we won't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants