Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for scan_uri_escapes #163

Open
Paalon opened this issue Jun 12, 2024 · 2 comments
Open

Add tests for scan_uri_escapes #163

Paalon opened this issue Jun 12, 2024 · 2 comments
Labels
Tests / CI

Comments

@Paalon
Copy link
Contributor

Paalon commented Jun 12, 2024

This function is not tested because, in spite of it uses Julia v0.3 function char, which is not available in Julia v0.4, we cannot observe related errors in our test sets.

YAML.jl/src/scanner.jl

Line 1580 in 45f5cd2

push!(bytes, char(parse_hex(prefix(stream.input, 2))))

@Paalon Paalon changed the title Add test for scan_uri_escapes Add tests for scan_uri_escapes Jun 12, 2024
@kescobo
Copy link
Collaborator

kescobo commented Jun 12, 2024

does it need a convert(Char...) or something?

@kescobo
Copy link
Collaborator

kescobo commented Jun 12, 2024

I see you addressed in #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tests / CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kescobo @Paalon