Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document YAXConfig #157

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Document YAXConfig #157

merged 3 commits into from
Aug 15, 2022

Conversation

gdkrmr
Copy link
Contributor

@gdkrmr gdkrmr commented Aug 15, 2022

I have added some documentation to YAXConfig. There are two fields that I don't know what they are doing, maybe someone can add something there.

@coveralls
Copy link

coveralls commented Aug 15, 2022

Pull Request Test Coverage Report for Build 2860495234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.25%

Totals Coverage Status
Change from base Build 2614664627: 0.0%
Covered Lines: 1120
Relevant Lines: 1529

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #157 (849b531) into master (923e04a) will not change coverage.
The diff coverage is n/a.

❗ Current head 849b531 differs from pull request most recent head 4fe6d28. Consider uploading reports for the commit 4fe6d28 to get more accurate results

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          12       12           
  Lines        1529     1529           
=======================================
  Hits         1120     1120           
  Misses        409      409           
Impacted Files Coverage Δ
src/YAXArrays.jl 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/YAXArrays.jl Outdated Show resolved Hide resolved
Co-authored-by: Felix Cremer <felix.cremer@dlr.de>
@gdkrmr gdkrmr mentioned this pull request Aug 15, 2022
src/YAXArrays.jl Outdated Show resolved Hide resolved
Co-authored-by: Felix Cremer <felix.cremer@dlr.de>
@gdkrmr
Copy link
Contributor Author

gdkrmr commented Aug 15, 2022

Thanks for the corrections. I'll wait for the tests and then I just merge!

@felixcremer felixcremer merged commit 6c5d123 into JuliaDataCubes:master Aug 15, 2022
@felixcremer
Copy link
Member

Thanks.

@gdkrmr
Copy link
Contributor Author

gdkrmr commented Aug 15, 2022

wtf. I pressed Ctrl-Enter to send the comment and it just merged everything .... hmmmm :-/

@gdkrmr
Copy link
Contributor Author

gdkrmr commented Aug 15, 2022

@felixcremer did you merge this?

@felixcremer
Copy link
Member

Yes I went ahead and merged it.

@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 2860466400

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.25%

Totals Coverage Status
Change from base Build 2614664627: 0.0%
Covered Lines: 1120
Relevant Lines: 1529

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants