Switch time string parsing to tryparse to handle Julia 1.6.6 change

[Wynand]

When parse(Time, str) fails for str="13:13:13142" on Ubuntu Julia 1.6.6, an ArgumentError is thrown instead of an InexactError, but when using tryparse nothing is returned

This switches updates the logic to handle the new return type

---

Reference links:

• InexactError removed: Remove throw InexactError from tryparsenext JuliaLang/julia#44004
• 1.7.3 branch with this change: https://github.com/JuliaLang/julia/commits/kc/1.7.3/stdlib/Dates/src/io.jl

[Wynand]

Turns out I was testing locally with Julia 1.6.5, and this fails locally with 1.6.6

[Wynand]

I'm not a fan of how errors from _trunc_seconds are effectively ignored by this

[Wynand]

Would it be worth while to just always call _trunc_seconds on str?

IE, to change this function to

pqparse(::Type{Time}, str::AbstractString) = parse(Time, _trunc_seconds(str))

[iamed2]

If it generates an InexactError on 1.6.5 AND current stable I think we have a case for this being a Julia bug in 1.6.6

[Wynand]

If it generates an InexactError on 1.6.5 AND current stable I think we have a case for this being a Julia bug in 1.6.6

My best guess is that this was introduced by this change: JuliaLang/julia#44004

When I test this on Julia 1.7 I get and InexactError, and the stacktrace uses tryparsenext:

julia> parse(Time, "13:13:13.13124")
ERROR: InexactError: convert(Dates.Decimal3, 13124)
Stacktrace:
 [1] tryparsenext
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/io.jl:153 [inlined]
 [2] tryparsenext
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/io.jl:41 [inlined]
 [3] macro expansion
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:64 [inlined]
 [4] tryparsenext_core(str::String, pos::Int64, len::Int64, df::DateFormat{Symbol("HH:MM:SS.s"), Tuple{Dates.DatePart{'H'}, Dates.Delim{Char, 1}, Dates.DatePart{'M'}, Dates.Delim{Char, 1}, Dates.DatePart{'S'}, Dates.Delim{Char, 1}, Dates.DatePart{'s'}}}, raise::Bool)
   @ Dates /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:38
 [5] macro expansion
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:150 [inlined]
 [6] tryparsenext_internal
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:125 [inlined]
 [7] parse
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:282 [inlined]
 [8] parse(::Type{Time}, str::String)
   @ Dates /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:281
 [9] top-level scope

This change isn't part of 1.7: https://github.com/JuliaLang/julia/blob/v1.7.2/stdlib/Dates/src/io.jl#L153
but it looks like it will be: https://github.com/JuliaLang/julia/commits/kc/1.7.3/stdlib/Dates/src/io.jl

[iamed2]

I'm confused; does tryparse throw an error sometimes? I would have thought we could get rid of the try-catch block if we used tryparse.

[Wynand]

I'm confused; does tryparse throw an error sometimes? I would have thought we could get rid of the try-catch block if we used tryparse.

Yes, in Julia 1.6.5 and 1.7.2 it throws InexactError, but in 1.6.6 (and probably 1.7.3) is just returns nothing.
This is because the MR linked in the description has been backported to 1.6 but hasn't been backported to 1.7

1.6.6:

   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.6.6 (2022-03-28)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using Dates

julia> tryparse(Time, "13:13:13.13142")

julia>

1.7.2:

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.7.2 (2022-02-06)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using Dates

julia> tryparse(Time, "13:13:13.13142")
ERROR: InexactError: convert(Dates.Decimal3, 13142)
Stacktrace:
 [1] tryparsenext
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/io.jl:153 [inlined]
 [2] tryparsenext
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/io.jl:41 [inlined]
 [3] macro expansion
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:64 [inlined]
 [4] tryparsenext_core(str::String, pos::Int64, len::Int64, df::DateFormat{Symbol("HH:MM:SS.s"), Tuple{Dates.DatePart{'H'}, Dates.Delim{Char, 1}, Dates.DatePart{'M'}, Dates.Delim{Char, 1}, Dates.DatePart{'S'}, Dates.Delim{Char, 1}, Dates.DatePart{'s'}}}, raise::Bool)
   @ Dates /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:38
 [5] macro expansion
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:150 [inlined]
 [6] tryparsenext_internal
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:125 [inlined]
 [7] tryparse
   @ /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:290 [inlined]
 [8] tryparse(::Type{Time}, str::String)
   @ Dates /usr/local/julia/share/julia/stdlib/v1.7/Dates/src/parse.jl:289
 [9] top-level scope
   @ REPL[2]:1

julia> 

[iamed2]

Let's put the new behaviour and old behaviour in there and guard with a @static if VERSION ... block, so that we can remove the error-handling when it's no longer necessary.

[Wynand]

Let's put the new behaviour and old behaviour in there and guard with a @static if VERSION ... block, so that we can remove the error-handling when it's no longer necessary.

I've added some version based logic

[iamed2]

Bump the version to 1.13 and we can merge and tag

[Wynand]

Bump the version to 1.13 and we can merge and tag

updated