-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GUID instead of UUID #378
Draft
ahjulstad
wants to merge
13
commits into
JuliaDatabases:main
Choose a base branch
from
ahjulstad:replace-uuid-with-guid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably breaks the test runner from the github action, but that is for fixing later.
It seems MariaDB returns UUIDs as strings, which might be a good idea.
This task has grown larger than what I was originally expecting, and help is needed on some items:
What I have now is a devcontainer setup with MariaDB and MSSQL, I have implemented a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #366 for me, but more testing (and unittests) is necessary.
As far as I can understand, the SQL GUID type, isn't really a UInt128, but rather a composite struct. (link
This PR adds a new GUID struct in the ODBC package, and uses that instead of Base.UUID.
As a lot of application code might expect to receive Base.UUID from results, some more thought should probably go into this.
Things to consider
Also, I have only tested this against a MSSQL database (my test rig in dev container here: https://github.com/ahjulstad/debug-julia-odbc ), so I have no idea if this breaks other databases.