Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to implicit leave change in Julia #614

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Mar 7, 2024

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.78%. Comparing base (f7138f9) to head (5925c95).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   85.05%   82.78%   -2.28%     
==========================================
  Files          12       12              
  Lines        2536     2399     -137     
==========================================
- Hits         2157     1986     -171     
- Misses        379      413      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a few other CI failures, but it looks like this commit fixes the issue at least. Let's move forward with this as it would help us debug the other issues.

@aviatesk aviatesk merged commit e0e34be into JuliaDebug:master Mar 10, 2024
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JuliaInterpreter hangs when handling errors on v1.11
3 participants