Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove One (again) #354

Closed
oxinabox opened this issue May 13, 2021 · 2 comments
Closed

Remove One (again) #354

oxinabox opened this issue May 13, 2021 · 2 comments
Milestone

Comments

@oxinabox
Copy link
Member

Yet again be bring this up.
making a new issue as it was mixed in with everything else.
past discussions #62
#61 (comment)

It is barely a valid differential.
It's actually just a scaling value for putting infront of a differential.
Or for using to seed.

I think it might only be used in a few scalar rules, and there it can be replaced with true.
Since it is just there to makes sure we generate dx->dx() so we currently end up generatign dx->One()dx but we can happily also just generate dx->true*x.

The One() type doesn't give enough wins, and is confusing.

@willtebbutt
Copy link
Member

willtebbutt commented May 13, 2021

We should remove it in the next breaking release.

edit: truth be told, I'd completely forgotten that we still have this.

@oxinabox oxinabox added this to the v0.10 milestone May 13, 2021
@oxinabox
Copy link
Member Author

oxinabox commented Jun 1, 2021

closed in #360

@oxinabox oxinabox closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants