Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on nightly due to type change #124

Closed
oxinabox opened this issue Mar 28, 2023 · 4 comments · Fixed by #125
Closed

Broken on nightly due to type change #124

oxinabox opened this issue Mar 28, 2023 · 4 comments · Fixed by #125
Assignees

Comments

@oxinabox
Copy link
Member

oxinabox commented Mar 28, 2023

From the tests

julia> using TestEnv; TestEnv.activate(); using Symbolics, Diffractor

julia> @variables ω α β γ δ ϵ ζ η
       (x1, c1) = ∂⃖{3}()(exp, ω)
ERROR: TypeError: in opaque_closure_method, expected Int64, got a value of type Int32

Some of the types have been truncated in the stacktrace for improved reading. To emit complete information
in the stack trace, evaluate `TruncatedStacktraces.VERBOSE[] = true` and re-run the code.

Stacktrace:
 [1] ∂⃖
   @ ~/JuliaEnvs/Diffractor.jl/src/stage1/generated.jl:223 [inlined]
 [2] (::∂⃖{3})(f::typeof(exp), args::Num)
   @ Diffractor ~/JuliaEnvs/Diffractor.jl/src/stage1/generated.jl:66
 [3] top-level scope
   @ REPL[38]:2

Nightly first failed with this on
22 Feb https://github.com/JuliaDiff/Diffractor.jl/actions/runs/4229848232
and last worked on
21 Feb https://github.com/JuliaDiff/Diffractor.jl/actions/runs/4229848232

So there is a narrow window in what change could have caused this failure

@oxinabox oxinabox self-assigned this Mar 28, 2023
@oxinabox oxinabox changed the title Broken on nightly due to Broken on nightly due to type change Mar 28, 2023
@oscardssmith
Copy link
Member

Is this the same as #122 or a separate breakage?

@oxinabox
Copy link
Member Author

oxinabox commented Mar 28, 2023

Pretty sure it is seperate, its a different error message.
And this breakage happened like over a month before that PR was merged

@oxinabox
Copy link
Member Author

Pretty sure the cause was JuliaLang/julia#48739

so somewhere with nargs being passed in

@oxinabox
Copy link
Member Author

Simpler test case:

julia> using Diffractor

julia> var"'" = Diffractor.PrimeDerivativeBack
Diffractor.PrimeDerivativeBack

julia> sin'''(1.0)

Needs at least 3rd derivative.
Interestingly once i put my current fix in 3rd works, but 4th segfaults...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants