Fix bug in Taylor1 constructor for mixtures and add tests #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! LGTM! Two questions:
|
I could not find any other occurrences of TaylorSeries.jl/src/calculus.jl Line 110 in 5895948 It seems to be working properly; for completeness, added anyway a test of integrate for mixtures.
Done! 😄 |
|
Excellent! Thanks for your contribution. I am merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342. Essentially,
fillwas used in aTaylor1constructor around hereTaylorSeries.jl/src/constructors.jl
Line 51 in 5895948
which according to the docs works fine when the underlying type is immutable, but causes issues for mutable types, such as
Array.