Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significant regression in benchmarks #72

Closed
Krastanov opened this issue Aug 8, 2023 · 4 comments · Fixed by #73
Closed

significant regression in benchmarks #72

Krastanov opened this issue Aug 8, 2023 · 4 comments · Fixed by #73
Assignees

Comments

@Krastanov
Copy link
Member

The whole point of ResumableFunctions is that it is much faster than Base.Channel tasks. That is still somewhat true, but the benchmarks (described in the README) have experienced significant loss of performance (with Int types).

These two should basically be the same, but currently there is a significant difference:

Direct: 
  23.115 ns (0 allocations: 0 bytes)
ResumableFunctions: 
  3.487 μs (249 allocations: 3.89 KiB)

After this is fixed, we should also add these benchmarks to the CI and we should add the check for zero allocations as an explicit test.

@gerlero
Copy link
Member

gerlero commented Aug 10, 2023

Well, this is bad.

we should also add these benchmarks to the CI and we should add the check for zero allocations as an explicit test.

Agreed.

@pepijndevos
Copy link
Contributor

I bisected the performance regression to 727ba4a

@Krastanov
Copy link
Member Author

@gerlero , any chance you can investigate this? It is probably some type instability in the modified iterate method that was introduced when yieldfrom was merged.

@gerlero
Copy link
Member

gerlero commented Sep 5, 2023

@pepijndevos thanks; that's #57 then. @Krastanov I'll take a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants