-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
significant regression in benchmarks #72
Comments
Well, this is bad.
Agreed. |
I bisected the performance regression to 727ba4a |
@gerlero , any chance you can investigate this? It is probably some type instability in the modified iterate method that was introduced when |
@pepijndevos thanks; that's #57 then. @Krastanov I'll take a look as soon as I can. |
The whole point of
ResumableFunctions
is that it is much faster thanBase.Channel
tasks. That is still somewhat true, but the benchmarks (described in the README) have experienced significant loss of performance (with Int types).These two should basically be the same, but currently there is a significant difference:
After this is fixed, we should also add these benchmarks to the CI and we should add the check for zero allocations as an explicit test.
The text was updated successfully, but these errors were encountered: